change appPath to accept bower.json config #254
Conversation
Change `appPath` variable to accept bower.json config as well as the `env` variable and option. The variable accepts values from the environment variable, the bower config file, the option, and then defaults to ‘app,’ in that order.
|
Why? |
|
Pull request #181 changed from the previous code in order to accept an appPath option. It looked more like what I am proposing, which also accepted a bower.json config. For some reason, the bower.json config option was removed then. The reason I am proposing to re-implement the bower.json configuration option is mostly due to the fact that it would be nice to use the bower config to scaffold the app path rather than relying on the I'm definitely open to rearranging the order of which the appPath should be accepted if that is something which should be explored. |
|
If the bower config option is pointless or redundant, this is more in an attempt to standardize the way that the angular and backbone generators accept the appPath option. Right now, the angular generator is using the old backbone generator's style and it'd be nice to standardize the two. |
|
If you choose bower.json as the place for the app-path configuration it will lead to a fragmented storage of generator options which i personally don't prefer. yo-rc.json defines a bit more that just the app-path and it seems to more consistent to keep all these generator specific options at one place - yo-rc.json looks at this time pragmatic and good enough to me. Just my 2 cents ;) |
|
@ajthor don't count on the angular generator keeping the bower.json app path because .... well it probably won't. The only reason its still there is I haven't got around to doing the same |
|
Closing this. |
Change
appPathvariable to accept bower.json config as well as theenvvariable and option. The variable accepts values from theenvironment variable, the bower config file, the option, and then
defaults to ‘app,’ in that order.